[PATCH] Fix trailing whitespace in new (!!!) code

Ralph Böhme slow at samba.org
Fri Apr 6 12:13:41 UTC 2018


On Fri, Apr 06, 2018 at 02:10:37PM +0200, Volker Lendecke wrote:
> On Fri, Apr 06, 2018 at 01:54:18PM +0200, Ralph Böhme via samba-technical wrote:
> > On Fri, Apr 06, 2018 at 01:48:34PM +0200, Volker Lendecke via samba-technical wrote:
> > > Attached find a patch that cleans up fresh code to match
> > > README.Coding. Gary, if you review Andrew's code in the future, can
> > > you please point him at the relevant section of README.Coding, quoted
> > > here for your convenience?
> > 
> > I messed this up many times as well, the only thing that helped me to avoid
> > this error was to configure my editor to highlight trailing whitespace. :)
> 
> Back to the original question: Can someone give a formal review, or is
> anything wrong with the patch?

sorry, +1 of course. Can you push as I already have an autobuild running?

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46



More information about the samba-technical mailing list