[PATCH] s3:smb2_tcon: Add check to prevent non-DFS clients from connecting to an msdfs proxy.

[Ralph Böhme]

On Fri, Apr 06, 2018 at 04:49:44PM +0200, Swen Schillig via samba-technical wrote:
> On Fri, 2018-04-06 at 16:47 +0200, Ralph Wuerthner wrote:
> > On 06.04.2018 16:27, Volker Lendecke wrote:
> > > On Fri, Apr 06, 2018 at 04:24:33PM +0200, Swen Schillig via samba-
> > > technical wrote:
> > > > > Another team reviewer?
> > > > 
> > > > Really ?
> > > > No README.Coding anymore ?
> > > > 
> > > > Referring to Jeremy's latest requirement regarding
> > > > function parameter list.
> > > 
> > > Ok, sorry, this is a copy&paste. NACK on this patch. Apologies.
> > > 
> > > Volker
> > > 
> > 
> > No problem. Please see my updated version.
> > 
> Subject line is by far too long.

It's often better to have a good commit message summary that can be grasped by
looking at git log --pretty=oneline even if it's a bit longer.

[slow at kazak scratch]$ git lo -1000 | awk '{ print length($0); }' | sort -nu | tail -10
140
141
143
145
146
147
148
149
157
308

[slow at kazak autobuild]$ git lo -1
736210bfcc5dee2cebd87ff09f83a6beeb8a579b s3:smb2_tcon: Add check to prevent non-DFS clients from connecting to an msdfs proxy.
[slow at kazak autobuild]$ git lo -1 | wc -m
127

Not that bad and a good summary. +1

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46