[PATCH] s3:smb2_tcon: Add check to prevent non-DFS clients from connecting to an msdfs proxy.

Swen Schillig swen at vnet.ibm.com
Fri Apr 6 15:46:20 UTC 2018


On Fri, 2018-04-06 at 17:28 +0200, Ralph Böhme wrote:
> On Fri, Apr 06, 2018 at 04:49:44PM +0200, Swen Schillig via samba-
> technical wrote:
> > On Fri, 2018-04-06 at 16:47 +0200, Ralph Wuerthner wrote:
> > > On 06.04.2018 16:27, Volker Lendecke wrote:
> > > > On Fri, Apr 06, 2018 at 04:24:33PM +0200, Swen Schillig via
> > > > samba-
> > > > technical wrote:
> > > > > > Another team reviewer?
> > > > > 
> > > > > Really ?
> > > > > No README.Coding anymore ?
> > > > > 
> > > > > Referring to Jeremy's latest requirement regarding
> > > > > function parameter list.
> > > > 
> > > > Ok, sorry, this is a copy&paste. NACK on this patch. Apologies.
> > > > 
> > > > Volker
> > > > 
> > > 
> > > No problem. Please see my updated version.
> > > 
> > 
> > Subject line is by far too long.
> 
> It's often better to have a good commit message summary that can be
> grasped by
> looking at git log --pretty=oneline even if it's a bit longer.
> 
> [slow at kazak scratch]$ git lo -1000 | awk '{ print length($0); }' |
> sort -nu | tail -10
> 140
> 141
> 143
> 145
> 146
> 147
> 148
> 149
> 157
> 308
> 
> [slow at kazak autobuild]$ git lo -1
> 736210bfcc5dee2cebd87ff09f83a6beeb8a579b s3:smb2_tcon: Add check to
> prevent non-DFS clients from connecting to an msdfs proxy.
> [slow at kazak autobuild]$ git lo -1 | wc -m
> 127
> 
> Not that bad and a good summary. +1

Fair enough.

I just gave Ralph all the feedback I received on some of my patches in
one go, trying to spare him a lengthy ping-pong of patch-updates and
reviews.

Since I cannot RB+ nor NACK, it only had recommendatory character
anyway.

Cheers Swen




More information about the samba-technical mailing list