[PATCH] Fix a few CIDs
Stefan Metzmacher
metze at samba.org
Tue Apr 3 21:37:18 UTC 2018
Am 03.04.2018 um 21:15 schrieb Volker Lendecke via samba-technical:
> From aba7235077357a8fc2c14c88a0c94522febda738 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Fri, 30 Mar 2018 11:02:35 -0500
> Subject: [PATCH 21/22] krb5_wrap: Fix CID 1414754 Resource leak
>
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
> lib/krb5_wrap/keytab_util.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/krb5_wrap/keytab_util.c b/lib/krb5_wrap/keytab_util.c
> index 5a72389..33b2ccc 100644
> --- a/lib/krb5_wrap/keytab_util.c
> +++ b/lib/krb5_wrap/keytab_util.c
> @@ -217,6 +217,7 @@ krb5_error_code kt_copy_one_principal(krb5_context context,
> krb5_set_error_message(context, ret,
> "failed to fetch principal %s",
> princ_string);
> + krb5_free_unparsed_name(context, princ_string);
> }
> } else {
> /* Not finding an enc type is not an error,
> -- 1.9.1
I just noticed that this is completely unused,
should we remove this instead of fixing?
git grep kt_copy_one_principal
lib/krb5_wrap/keytab_util.c:krb5_error_code
kt_copy_one_principal(krb5_context context,
lib/krb5_wrap/krb5_samba.h:krb5_error_code
kt_copy_one_principal(krb5_context context,
metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180403/8e926e6c/signature.sig>
More information about the samba-technical
mailing list