[PATCH] Fix a few CIDs

[Stefan Metzmacher]

Hi Volker,

> From 73e14e4b76b99397bd47b1fc7e3e90f66d16cad4 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Fri, 30 Mar 2018 11:00:33 -0500
> Subject: [PATCH 20/22] krb5_wrap: Fix a logic error
> 
> krb5_unparse_name returns 0 on success
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  lib/krb5_wrap/keytab_util.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/krb5_wrap/keytab_util.c b/lib/krb5_wrap/keytab_util.c
> index fd8308c..5a72389 100644
> --- a/lib/krb5_wrap/keytab_util.c
> +++ b/lib/krb5_wrap/keytab_util.c
> @@ -213,7 +213,7 @@ krb5_error_code kt_copy_one_principal(krb5_context context,
>  	if (!found_one) {
>  	    char *princ_string;
>  	    int ret2 = krb5_unparse_name (context, princ, &princ_string);
> -	    if (ret2) {
> +	    if (ret2 == 0) {
>  		krb5_set_error_message(context, ret,
>  					"failed to fetch principal %s",
>  					princ_string);
> -- 1.9.1

I don't understand this, should we set an error message on success?

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180403/c065c77c/signature.sig>