Resend: Patch to implement utimes in smbclient along with a test
Volker.Lendecke at SerNet.DE
Fri Sep 22 01:01:01 UTC 2017
On Thu, Sep 21, 2017 at 05:33:00PM -0700, Richard Sharpe wrote:
> On Thu, Sep 21, 2017 at 5:19 PM, Volker Lendecke
> <Volker.Lendecke at sernet.de> wrote:
> > Hi, Richard!
> > On Thu, Sep 21, 2017 at 04:25:54PM -0700, Richard Sharpe via samba-technical wrote:
> >> Attached is a patch to implement a utimes command in smbclient along
> >> with a test.
> > Let me cite a snippet from README.Coding:
> > * Maximum Line Width is 80 Characters
> > The reason is not about people with low-res screens but rather sticking
> > to 80 columns prevents you from easily nesting more than one level of
> > if statements or other code blocks. Use source3/script/count_80_col.pl
> > to check your changes.
> Here is a change that fixes the added line that causes problems, I think.
For me it does not, sorry. Line 4964 in source3/client/client.c after
applying this patch is overlong for me. Just by 2 characters, but my
editor shows red for that new line.
Don't get me wrong. I will not NACK your patch over this, so if Jeremy
likes it, he is of course free to put it in.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical