[PATCH] libsmbclient APIs to set configuration file and Logging callback function

[Andrew Bartlett]

On Wed, 2017-09-20 at 17:42 -0400, Puran Chand wrote:
> Hi, 
> 
> Added private_ptr to smbc_setLogCallback().
> 
> Attached updated patch file.

Can you add a test please?

Ideally examples/libsmbclient would be built and hooked in to the test
system, but that is probably too much work.  

There is a smaller test suite in:
source4/torture/libsmbclient/libsmbclient.c

Thanks,

Andrew Bartlett

> - Puran
> 
> On Wed, Sep 20, 2017 at 4:00 PM, Puran Chand <puran157 at gmail.com>
> wrote:
> > Oops, missed that, working on it.
> > 
> > Regarding documentation, is it okay if I document this in
> > libsmbclient.h?
> > 
> > Thanks
> > 
> > -Puran
> > 
> > On Wed, Sep 20, 2017 at 3:32 PM, Andrew Bartlett <abartlet at samba.or
> > g> wrote:
> > > On Wed, 2017-09-20 at 14:49 -0400, Puran Chand via samba-
> > > technical
> > > wrote:
> > > > Hi All,
> > > >
> > > > Gentle reminder.
> > > >
> > > > This patch has trivial changes (I think).
> > > > A quick review is highly appreciated.
> > > 
> > > Shouldn't smbc_setLogCallback() also pass in the private pointer?
> > > 
> > > It should also be clearly documented that the impact of these is
> > > global, not local the the libsmbclient context.
> > > 
> > > Andrew Bartlett
> > > --
> > > Andrew Bartlett                       http://samba.org/~abartlet/
> > > Authentication Developer, Samba Team  http://samba.org
> > > Samba Developer, Catalyst IT          http://catalyst.net.nz/serv
> > > ices/samba
> > > 
> > > 
> > 
> > 
> 
> 
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba