[PATCH] libsmbclient APIs to set configuration file and Logging callback function

[Puran Chand]

Hi,

Added private_ptr to smbc_setLogCallback().

Attached updated patch file.

- Puran

On Wed, Sep 20, 2017 at 4:00 PM, Puran Chand <puran157 at gmail.com> wrote:

> Oops, missed that, working on it.
>
> Regarding documentation, is it okay if I document this in libsmbclient.h?
>
> Thanks
>
> -Puran
>
> On Wed, Sep 20, 2017 at 3:32 PM, Andrew Bartlett <abartlet at samba.org>
> wrote:
>
>> On Wed, 2017-09-20 at 14:49 -0400, Puran Chand via samba-technical
>> wrote:
>> > Hi All,
>> >
>> > Gentle reminder.
>> >
>> > This patch has trivial changes (I think).
>> > A quick review is highly appreciated.
>>
>> Shouldn't smbc_setLogCallback() also pass in the private pointer?
>>
>> It should also be clearly documented that the impact of these is
>> global, not local the the libsmbclient context.
>>
>> Andrew Bartlett
>> --
>> Andrew Bartlett                       http://samba.org/~abartlet/
>> Authentication Developer, Samba Team  http://samba.org
>> Samba Developer, Catalyst IT          http://catalyst.net.nz/service
>> s/samba
>>
>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-libsmbclient-APIs-for-setting-configuration-fi.patch
Type: text/x-patch
Size: 13539 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170920/0cc7c197/0001-Added-libsmbclient-APIs-for-setting-configuration-fi.bin>