[PATCH] libsmbclient APIs to set configuration file and Logging callback function
puran157 at gmail.com
Wed Sep 20 21:42:22 UTC 2017
Added private_ptr to smbc_setLogCallback().
Attached updated patch file.
On Wed, Sep 20, 2017 at 4:00 PM, Puran Chand <puran157 at gmail.com> wrote:
> Oops, missed that, working on it.
> Regarding documentation, is it okay if I document this in libsmbclient.h?
> On Wed, Sep 20, 2017 at 3:32 PM, Andrew Bartlett <abartlet at samba.org>
>> On Wed, 2017-09-20 at 14:49 -0400, Puran Chand via samba-technical
>> > Hi All,
>> > Gentle reminder.
>> > This patch has trivial changes (I think).
>> > A quick review is highly appreciated.
>> Shouldn't smbc_setLogCallback() also pass in the private pointer?
>> It should also be clearly documented that the impact of these is
>> global, not local the the libsmbclient context.
>> Andrew Bartlett
>> Andrew Bartlett http://samba.org/~abartlet/
>> Authentication Developer, Samba Team http://samba.org
>> Samba Developer, Catalyst IT http://catalyst.net.nz/service
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 13539 bytes
Desc: not available
More information about the samba-technical