[PATCH] tfork fix issues with waiter process termination

Ralph Böhme slow at samba.org
Sat Sep 16 14:52:51 UTC 2017

On Sat, Sep 16, 2017 at 10:13:37AM +0000, Gary Lockyer wrote:
> > Your fix for the status fd is spot on, I'd like to change the event fd fix
> > however. Depending on whether tfork_event_fd() has been called, ownership of the
> > event fd should be transferred to the caller.
> That makes more sense as it will reduce the chances of file descriptor
> leaks.
> > 
> > Please take a look at attached patchset. The FIXUP commits are some minor
> > fixes. The event fd changes are in the "lib/util: only close the event_fd in
> > tfork if the caller didn't call tfork_event_fd()" commit.
> I'm happy with the revised patch set.


We also need a backport for 4.7, don't we? metze already created a bug for this
one, so I'm going to add the bug URL and push later on if I don't hear any



More information about the samba-technical mailing list