[PATCH] tfork fix issues with waiter process termination

[Gary Lockyer]

On 16/09/17 20:29, Ralph Böhme via samba-technical wrote:
> Hi Gary
> 
> On Fri, Sep 15, 2017 at 11:39:15PM +0000, Ralph Böhme via samba-technical wrote:
>> On Thu, Sep 14, 2017 at 05:23:47AM +0000, Gary Lockyer via samba-technical wrote:
>>> Patches to fix issues with waiter process termination and the closing of
>>> the event FD, see the commit comments for a detailed description.
>>
>> thanks a *lot* for working on this. Looking at this and the other patches right
>> now...
> 
> goodness, glad you spotted this before the 4.7 release. Guess you had some fun
> debugging this, I probably ruined a few weekends of yours and owe you a beerFortunately? I had similar issues refactoring the process model, so I
knew how to proceed.
> 
> Your fix for the status fd is spot on, I'd like to change the event fd fix
> however. Depending on whether tfork_event_fd() has been called, ownership of the
> event fd should be transferred to the caller.
That makes more sense as it will reduce the chances of file descriptor
leaks.
> 
> Please take a look at attached patchset. The FIXUP commits are some minor
> fixes. The event fd changes are in the "lib/util: only close the event_fd in
> tfork if the caller didn't call tfork_event_fd()" commit.
I'm happy with the revised patch set.
> 
> -slow
> 
Gary