[PATCH] Use Intel AES instruction set if it exists - v3

Stefan Metzmacher metze at samba.org
Wed Sep 6 18:52:58 UTC 2017

Am 06.09.2017 um 18:15 schrieb Jeremy Allison:
> On Wed, Sep 06, 2017 at 03:38:20PM +0200, Stefan Metzmacher wrote:
>> Hi Jeremy,
>> can you please check the indentation in various wscript files,
>> they're python scripts and should not use tabs, 4 spaces.
>> Also running "git show eb1f476657c" in a recent kernel checkout,
>> gives a failure.
> That's a Samba hash, not a kernel one.

No, that's the hash of the file content and I'd assume that doesn't
change if we just copy the file.

>> Can you please make sure we important a well defined state
>> of arch/x86/crypto/aesni-intel_asm.S from the kernel,
>> including the exact full commit hash of the checkout
>> you used in our commit message.
>> git show $commit:arch/x86/crypto/aesni-intel_asm.S should
>> should exactly what we import.
>> This will make it much easier to track what state we have.
> That's a good idea and will help us track any changes
> made for security.
>> There have been some changes this year regarding AES-GCM
>> (which we don't use yet, but may want to experiment with).
>> So I think it would be good to import the recent version from the
>> kernel.
> I'll take a look.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170906/b911314a/signature.sig>

More information about the samba-technical mailing list