[PATCH] Use Intel AES instruction set if it exists - v3

Jeremy Allison jra at samba.org
Wed Sep 6 16:15:15 UTC 2017

On Wed, Sep 06, 2017 at 03:38:20PM +0200, Stefan Metzmacher wrote:
> Hi Jeremy,
> can you please check the indentation in various wscript files,
> they're python scripts and should not use tabs, 4 spaces.
> Also running "git show eb1f476657c" in a recent kernel checkout,
> gives a failure.

That's a Samba hash, not a kernel one.

> Can you please make sure we important a well defined state
> of arch/x86/crypto/aesni-intel_asm.S from the kernel,
> including the exact full commit hash of the checkout
> you used in our commit message.
> git show $commit:arch/x86/crypto/aesni-intel_asm.S should
> should exactly what we import.
> This will make it much easier to track what state we have.

That's a good idea and will help us track any changes
made for security.

> There have been some changes this year regarding AES-GCM
> (which we don't use yet, but may want to experiment with).
> So I think it would be good to import the recent version from the
> kernel.

I'll take a look.

More information about the samba-technical mailing list