[PATCH] Ensure default SMB_VFS_GETWD() call can't return a partially completed struct smb_filename.

Jeremy Allison jra at samba.org
Tue Oct 3 00:43:48 UTC 2017


When I converted SMB_VFS_GETWD() to return a struct smb_filename *
I messed up and allowed it to return a partially constructed
struct if the underlying sys_getwd() returned NULL (i.e. I didn't immediately
return NULL if sys_getwd() failed).

Found whilst investigating a different bug, but this is a pretty
obvious fix. Only affects 4.7 as that contains the struct smb_filename *
VFS changes.

Please review and push for master if happy !

Cheers,

Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-VFS-Ensure-default-SMB_VFS_GETWD-call-can-t-retur.patch
Type: text/x-diff
Size: 949 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171002/658d73a7/0001-s3-VFS-Ensure-default-SMB_VFS_GETWD-call-can-t-retur.diff>


More information about the samba-technical mailing list