Latest Time Machine Patch
slow at samba.org
Wed Oct 4 08:01:19 UTC 2017
On Tue, Oct 03, 2017 at 10:58:40PM +0000, Jeremy Allison wrote:
> On Tue, Oct 03, 2017 at 06:57:35PM -0400, Kevin Anderson wrote:
> > > Yes, these look good to me. Just one request - did you check this
> > > under valgrind to ensure it's clean ? If so then RB+ from me.
> > >
> > I've never run valgrind before so this was the first time attempting to do so.
> > I ran valgrind --leak-check=yes <smbd> both with the Avahi patch and
> > without it (including starting a backup). The output for "definitely
> > lost" remained the same at 2 bytes in 1 block. Should I compare other
> > numbers as well?
> > Kevin Anderson
> Nope, sounds good - thanks for checking ! Can I get a second
> Team reivewer ?
pushed. And sorry for the sloppy review and not insisting on the memory
More information about the samba-technical