samba.tests.dsdb is not idempotent

[Andreas Schneider]

On Friday, 24 November 2017 19:57:49 CET Andrew Bartlett via samba-technical 
wrote:
> On Fri, 2017-11-24 at 16:02 +0100, Andreas Schneider wrote:
> > Hi Lumír,
> > 
> > 
> > the attached patch cleans up the tests and creates a temporary user
> > instead of tainting the Administrator account!
> > 
> > This should fix your problem.
> > 
> > 
> > Could a Samba Team member please review the patch and push if OK?
> 
> The only part I don't like is the fixed password.  While fine here, I
> think it is a habit we should avoid.
> 
> diff --git a/python/samba/tests/dsdb.py b/python/samba/tests/dsdb.py
> index d35f3bb..493ea25 100644
> --- a/python/samba/tests/dsdb.py
> +++ b/python/samba/tests/dsdb.py
> @@ -45,7 +45,7 @@ class DsdbTests(TestCase):
>  
>          # Create a test user
>          user_name = "samdb-testuser"
> -        user_pass = "1qazXS at W"
> +        user_pass = samba.generate_random_password(32, 32)
>          user_description = "Test user for dsdb test"
>  
>          base_dn = self.samdb.domain_dn()
> 
> If you are OK with the amended patch, then I or you can push it.
> 
> Thanks!

Pushed, thanks!


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org