[PATCHES v2] Fix FreeBSD developer build
uri at samba.org
Thu Nov 23 05:06:41 UTC 2017
On 11/23/2017 06:46 AM, Timur I. Bakeyev wrote:
> Hi, Uri!
> On Wed, Nov 22, 2017 at 1:15 AM, Andrew Bartlett <abartlet at samba.org
> <mailto:abartlet at samba.org>> wrote:
> On Tue, 2017-11-21 at 21:25 +0200, Uri Simchoni via samba-technical
> > Hi,
> > Attached version 3 - same as v2, but with added 3 patches at the end,
> > which allow FreeBSD developer build to run without the ADDITIONAL_CFLAGS
> > workaround, and without breaking Linux...
> > Some responses below.
> I like this approach.
> Attached is what I'm happy with, which is under a private autobuild.
> This should then allow broader review of the remaining changes, without
> the weight of the larger patch set.
> I see that reviewed patches are landed in the HEAD already, which is
> great. Would you mind to send a renewed patch-set with the remaining
> patches from the v3?
> With regards,
> Timur Bakeyev.
I will, in due course. I have a day job, you know :) Some need rework
following comments (the ACL stuff and pragmas).
Yesterday I resubmitted two of the patches to the cwrap project, because
they have to land there first before landing in Samba (when a new
version of pam_wrapper or other wrapper is released, it replaces the
current version in Samba, private patches are not kept).
I also started playing with "make test" - it's not a total disaster.
After ~1600 test suites out of ~2100 with ~100 failed ones it stopped
because time was exceeded. But let's not forget the ~1500 successful
ones! At least some of the failures were due to failures to setup a
specific env. Whenever you can't setup an env it fails multiple tests.
More information about the samba-technical