[PATCHES v2] Fix FreeBSD developer build

[Timur I. Bakeyev]

Hi, Uri!

On Tue, Nov 21, 2017 at 8:25 PM, Uri Simchoni <uri at samba.org> wrote:

> Hi,
>
> Attached version 3 - same as v2, but with added 3 patches at the end,
> which allow FreeBSD developer build to run without the ADDITIONAL_CFLAGS
> workaround, and without breaking Linux...
>
> Some responses below.
>
>
For the " [PATCH v3 31/38] lib/replace: ignore readline -Wstrict-prototypes
warning" there is a simpler and more official work-around available, we
have it in the ports like:
.if ${readline_ARGS} == port
CFLAGS+=      -D_FUNCTION_DEF
.endif

See https://lists.gnu.org/archive/html/bug-readline/2014-04/msg00018.html

So I'd rather add _FUNCTION_DEF flag to CFLAGS in case readline > 6.3 is
used.

With regards,
Timur Bakeyev.