[PATCHES v2] Fix FreeBSD developer build
abartlet at samba.org
Wed Nov 22 09:19:06 UTC 2017
On Wed, 2017-11-22 at 05:13 +0100, Timur I. Bakeyev wrote:
> On Wed, Nov 22, 2017 at 2:18 AM, Andrew Bartlett <abartlet at samba.org> wrote:
> > On Wed, 2017-11-22 at 13:15 +1300, Andrew Bartlett via samba-technical
> > wrote:
> > > On Tue, 2017-11-21 at 21:25 +0200, Uri Simchoni via samba-technical
> > > wrote:
> > > > Hi,
> > > >
> > > > Attached version 3 - same as v2, but with added 3 patches at the end,
> > > > which allow FreeBSD developer build to run without the ADDITIONAL_CFLAGS
> > > > workaround, and without breaking Linux...
> > Signed-off-by: Uri Simchoni <uri at samba.org>
> > Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> From my side I'd also try to verify patches within ports infrastructure against master, but need to prepare such an environment, so that would be a bit later.
> Meanwhile, Uri mentioned problems with the ABI checks and I've looked into that on FreeBSD. There are some issues with the current abi_gen.sh script and, seems, the way how libs are build on FreeBSD(or in the port).
You don't need to worry about the ABI stuff, just disable it.
The ABI script is Linux specific and as our ABI is (almost) never
changed between build targets, and as we don't have a way to store the
different ABIs anyway, it is all moot. As long as one build on the way
to master checks the ABIs we are good.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical