[PATCHES v2] Fix FreeBSD developer build

Timur I. Bakeyev timur at freebsd.org
Wed Nov 22 04:13:05 UTC 2017

On Wed, Nov 22, 2017 at 2:18 AM, Andrew Bartlett <abartlet at samba.org> wrote:

> On Wed, 2017-11-22 at 13:15 +1300, Andrew Bartlett via samba-technical
> wrote:
> > On Tue, 2017-11-21 at 21:25 +0200, Uri Simchoni via samba-technical
> > wrote:
> > > Hi,
> > >
> > > Attached version 3 - same as v2, but with added 3 patches at the end,
> > > which allow FreeBSD developer build to run without the
> > > workaround, and without breaking Linux...
>     Signed-off-by: Uri Simchoni <uri at samba.org>
>     Reviewed-by: Andrew Bartlett <abartlet at samba.org>

>From my side I'd also try to verify patches within ports infrastructure
against master, but need  to prepare such an environment, so that would be
a bit later.

Meanwhile, Uri mentioned problems with the ABI checks and I've looked into
that on FreeBSD. There are some issues with the current abi_gen.sh script
and, seems, the way how libs are build on FreeBSD(or in the port).

FreeBSD11.* comes with gdb version 6, through the ports version 8 can be
installed. Both versions give smth like:

(gdb) p smbc_fgetxattr
$1 = {int (int, const char *, const void *, size_t)} 0xba60 <smbc_fgetxattr>

which is far from the expected:

int (int, const char *, const void *, size_t)

I wonder what version of gdb do you use for ABI checks? Luckily, we can get
almost the same output with:

(gdb) whatis smbc_fgetxattr
type = int (int, const char *, const void *, size_t)

which is almost what we need and what is easy to fix with some sed magic.
It doesn't help that, it seems, `sort` results do vary on FreeBSD and
Linux(or sorted differently in the .sigs by Python).

Well, I hope to nail that part soon. Would it be possible to use `whatis`
instead of `p` on Linux also?

With regards,
Timur Bakeyev.

More information about the samba-technical mailing list