Fwd: socket_wrapper changes and ctdb

[Amitay Isaacs]

On Tue, Nov 21, 2017 at 9:09 PM, Andreas Schneider <asn at samba.org> wrote:

> On Wednesday, 15 November 2017 10:17:46 CET Amitay Isaacs via
> samba-technical
> wrote:
> > Hi Andreas,
> >
> > On Wed, Nov 15, 2017 at 2:34 AM, Andreas Schneider via samba-technical <
> >
> > samba-technical at lists.samba.org> wrote:
> > > Hi,
> > >
> > > I'm currently trying to move the wrappers to the third_party directory.
> > > I've
> > > also changed the ctdb wscript but it always fails in autobuild now.
> > >
> > > It fails with:
> > >
> > > cp: cannot stat ‘/memdisk/asn/a/b3961373/ctdb/ctdb/tests/var/
> > > unit_eventscripts/etc/iproute2/rt_tables’: No such file or directory
> > > Aborted (core dumped)
> > > make: *** [autotest] Error 1
> > >
> > > which seems to be unrelated. The logs are here:
> > >
> > > https://git.samba.org/asn/samba-autobuild/ctdb.stdout
> > > https://git.samba.org/asn/samba-autobuild/ctdb.stderr
> >
> > Looks like you uncovered a race condition in sock_daemon code.  I am
> working
> > on some improvements in sock_daemon. Will post the patches in a day or
> two
> > after fixing the race condition.
>
> Hi Amitay,
>
> I've just saw that some sock_daemon patches went in. I've tried to push my
> branch again, but it fails at the same test.
>
> https://git.samba.org/asn/samba-autobuild/ctdb.stdout
> https://git.samba.org/asn/samba-autobuild/ctdb.stderr
>
>
Wow.  Now it's a different failure. :-)

Here is the patch that fixes the test code.

It's surprising that the tests pass without the cwrap patches
(moving socket wrapper to third_party).  So something has
changed in the socket_wrapper code.

Amitay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ctdb-tests-Make-sure-child-processes-are-waited-on-a.patch
Type: text/x-patch
Size: 1558 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171122/7b5ab697/0001-ctdb-tests-Make-sure-child-processes-are-waited-on-a.bin>