Bug in ctdb_recovery_helper ?

[Ralph Böhme]

Hi Amitay,

while going through ctdb_recovery_helper I noticed that in
recovery_active_done() we count the number of nodes but neither use it in
afterwards in this function nor anywhere else as we don't update the state with
the new count. Is this by design or a bug?

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
-------------- next part --------------
From e9c7de6e308f6f3e150758ee8d0b48effbbdfd54 Mon Sep 17 00:00:00 2001
From: Ralph Boehme <slow at samba.org>
Date: Sat, 11 Nov 2017 16:02:42 +0100
Subject: [PATCH] ctdb_recovery_helper: new lmaster count wasn't stored and
 used

---
 ctdb/server/ctdb_recovery_helper.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ctdb/server/ctdb_recovery_helper.c b/ctdb/server/ctdb_recovery_helper.c
index ab9ab4152b0..0aeb1fa61dd 100644
--- a/ctdb/server/ctdb_recovery_helper.c
+++ b/ctdb/server/ctdb_recovery_helper.c
@@ -2426,6 +2426,7 @@ static void recovery_active_done(struct tevent_req *subreq)
 
 	talloc_free(state->vnnmap);
 	state->vnnmap = vnnmap;
+	state->count = count;
 
 	ctdb_req_control_start_recovery(&request);
 	subreq = ctdb_client_control_multi_send(state, state->ev,
-- 
2.13.6