[PATCH] Harden Samba module functions

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed May 31 08:16:40 UTC 2017


On Wed, May 31, 2017 at 09:32:43AM +0200, Andreas Schneider via samba-technical wrote:
> On Tuesday, 30 May 2017 23:06:35 CEST Jeremy Allison wrote:
> > On Tue, May 30, 2017 at 04:08:32PM +0200, Andreas Schneider via samba-
> technical wrote:
> > > Hi,
> > > 
> > > the attached patch hardens the samba module functions and adds tests.
> > > 
> > > 
> > > Please review.
> > 
> > Reviewing now...
> > 
> > Can we eventually remove the capability to load any modules by
> > an absolute path altogether, and insist this is only done from
> > inside our modules directories ?
> > 
> > This will break (a few I'm guessing) existing smb.conf files,
> > so we should document and make the change for the next major
> > release if we're going to do this.
> 
> Yes, why not. I would push the current patchset and start working from there 
> ...

To be honest, I'm not happy with the #ifdef DEVELOPER. Is there a way
to avoid that?

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list