[PATCH] Harden Samba module functions

Stefan Metzmacher metze at samba.org
Wed May 31 08:45:01 UTC 2017

Am 31.05.2017 um 10:16 schrieb Volker Lendecke via samba-technical:
> On Wed, May 31, 2017 at 09:32:43AM +0200, Andreas Schneider via samba-technical wrote:
>> On Tuesday, 30 May 2017 23:06:35 CEST Jeremy Allison wrote:
>>> On Tue, May 30, 2017 at 04:08:32PM +0200, Andreas Schneider via samba-
>> technical wrote:
>>>> Hi,
>>>> the attached patch hardens the samba module functions and adds tests.
>>>> Please review.
>>> Reviewing now...
>>> Can we eventually remove the capability to load any modules by
>>> an absolute path altogether, and insist this is only done from
>>> inside our modules directories ?
>>> This will break (a few I'm guessing) existing smb.conf files,
>>> so we should document and make the change for the next major
>>> release if we're going to do this.
>> Yes, why not. I would push the current patchset and start working from there 
>> ...
> To be honest, I'm not happy with the #ifdef DEVELOPER. Is there a way
> to avoid that?

The same here, why do we need to skip loading the module depending on
a specific name at all, I'd like to avoid a having this code at all.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170531/91a7d881/signature.sig>

More information about the samba-technical mailing list