[PATCHSET] support FSCTL_DUPLICATE_EXTENTS_TO_FILE
slow at samba.org
Wed May 10 11:20:31 UTC 2017
On Wed, May 10, 2017 at 01:02:19PM +0200, David Disseldorp wrote:
> On Wed, 10 May 2017 12:20:21 +0200, Aurélien Aptel via samba-technical wrote:
> > It's been around a year since I last looked at this but it seems we are
> > changing the VFS API here (adding a flag param to the copy chunk vfs
> > function) shouldn't the version be bumped?
> The VFS API was bumped from 36 to 37 for 306783d6f5d5 since the last
> (4.6) release, so a further bump without any releases in between is
> unnecessary IMO.
> > I've attended Jeremy's VFS talk last week at SambaXP and he mentionned
> > we should be careful about changing that API and generally avoid
> > breaking things, similar to the kernel.
> There are no VFS API stability grantees, it's best-effort. 306783d6f5d5
> already makes API 37 significantly different to the previous version,
> so I'd prefer to keep the new flags parameter.
we guarantee to keep it unmodified within a x.y release, but going from x.y to
x.y+1 can change it.
More information about the samba-technical