David Disseldorp ddiss at suse.de
Wed May 10 11:02:19 UTC 2017

On Wed, 10 May 2017 12:20:21 +0200, Aurélien Aptel via samba-technical wrote:

> It's been around a year since I last looked at this but it seems we are
> changing the VFS API here (adding a flag param to the copy chunk vfs
> function) shouldn't the version be bumped?

The VFS API was bumped from 36 to 37 for 306783d6f5d5 since the last
(4.6) release, so a further bump without any releases in between is
unnecessary IMO.

> I've attended Jeremy's VFS talk last week at SambaXP and he mentionned
> we should be careful about changing that API and generally avoid
> breaking things, similar to the kernel.

There are no VFS API stability grantees, it's best-effort. 306783d6f5d5
already makes API 37 significantly different to the previous version,
so I'd prefer to keep the new flags parameter.

Cheers, David

More information about the samba-technical mailing list