[PATCH] Messaging improvements and fixes needed for auth logging

[Andrew Bartlett]

On Thu, 2017-03-23 at 12:26 -0700, Jeremy Allison wrote:
> On Thu, Mar 23, 2017 at 11:58:06AM -0700, Jeremy Allison via samba-
> technical wrote:
> > On Fri, Mar 24, 2017 at 07:52:46AM +1300, Andrew Bartlett wrote:
> > > > Sorry, thought it was a pretty obvious fix. The
> > > > tests on top should make sure we don't regress here.
> > > 
> > > While entirely reasonable to split up, and we can differ on the
> > > API, I
> > > think we should keep the logic changes in the original patch. 
> > > 
> > > Otherwise I don't see how we delete names once the last user is
> > > de-
> > > registered.
> > 
> > Yeah, you're probably right, sorry. I'll restructure this so your
> > tests go in first + the knownfail, then the fix, then
> > the -knownfail. Once all the make tests pass I'll repost
> > for review. That should make sure we don't regress.
> 
> And here it is ! Contents are:
> 
> Patches 1-3 - Additional tests from Andrew showing the bug +
> knownfail. RB+ me.
> Patch 4 - Fix for the bug from both Volker + Andrew - knownfail
> entry.
> 
> As patch #4 contains elements of both Volker's and Andrew's patches
> I've
> marked it:
> 
> Signed-off-by: Andrew Bartlett <abartlet at samba.org>
> Signed-off-by: Volker Lendecke <vl at samba.org>
> 
> and rb+ me.
> 
> With this we pass the new test demonstrating the bug.
> 
> Sorry for the long process, but we all got there in the
> end :-).
> 
> Please review and push if happy !

This looks great, I've pushed it to autobuild.

Andrew Bartlett