[PATCH] Messaging improvements and fixes needed for auth logging

[Andrew Bartlett]

On Fri, 2017-03-24 at 09:49 +1300, Andrew Bartlett via samba-technical
wrote:
> On Thu, 2017-03-23 at 12:26 -0700, Jeremy Allison wrote:
> > On Thu, Mar 23, 2017 at 11:58:06AM -0700, Jeremy Allison via samba-
> > technical wrote:
> > > On Fri, Mar 24, 2017 at 07:52:46AM +1300, Andrew Bartlett wrote:
> > > > > Sorry, thought it was a pretty obvious fix. The
> > > > > tests on top should make sure we don't regress here.
> > > > 
> > > > While entirely reasonable to split up, and we can differ on the
> > > > API, I
> > > > think we should keep the logic changes in the original patch. 
> > > > 
> > > > Otherwise I don't see how we delete names once the last user is
> > > > de-
> > > > registered.
> > > 
> > > Yeah, you're probably right, sorry. I'll restructure this so your
> > > tests go in first + the knownfail, then the fix, then
> > > the -knownfail. Once all the make tests pass I'll repost
> > > for review. That should make sure we don't regress.
> > 
> > And here it is ! Contents are:
> > 
> > Patches 1-3 - Additional tests from Andrew showing the bug +
> > knownfail. RB+ me.
> > Patch 4 - Fix for the bug from both Volker + Andrew - knownfail
> > entry.
> > 
> > As patch #4 contains elements of both Volker's and Andrew's patches
> > I've
> > marked it:
> > 
> > Signed-off-by: Andrew Bartlett <abartlet at samba.org>
> > Signed-off-by: Volker Lendecke <vl at samba.org>
> > 
> > and rb+ me.
> > 
> > With this we pass the new test demonstrating the bug.
> > 
> > Sorry for the long process, but we all got there in the
> > end :-).
> > 
> > Please review and push if happy !
> 
> This looks great, I've pushed it to autobuild.

We hit some issues, as the change to now give a not-found error
uncovered an issue in the samba-tool processes test, which Jeremy is
looking into.  (The 'samba' server name disappears unexpectedly). 

A patch in this series papers over that issue, but we need to come back
with a patch that asserts that all the expected messaging contexts
remain present.  It would be worthwhile anyway, as that could help a
lot with diagnosing server death as a case of flapping tests.

Anyway, to ensure everyone is working on the same base set of tests,
here is a patch with the building blocks, including the agreed fix from
last week.  It also includes the formatting fixes asked for after the
initial patch submission, and tests to show that Samba messaging
actually works in python.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba
-------------- next part --------------
A non-text attachment was scrubbed...
Name: just-messaging-fixes.patch
Type: text/x-patch
Size: 35286 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170328/c4107dac/just-messaging-fixes.bin>