[PATCH] Messaging improvements and fixes needed for auth logging

[Andrew Bartlett]

On Mon, 2017-03-20 at 15:08 -0700, Jeremy Allison wrote:
> On Mon, Mar 20, 2017 at 08:21:13PM +1300, Andrew Bartlett via samba-
> technical wrote:
> > To test the auth and authz logging, we decided to use the messaging
> > layer (details in our auth-logging branch in Catalyst's repo), as
> > we
> > have bindings for that in python.
> > 
> > It turned out that there were a number of issues in these layers,
> > both
> > the incomplete python bindings (they never previously worked: the
> > tests
> > were not actually tests) and an issue in the serverid database due
> > to
> > the way tdb_fetch_talloc() behaved with zero-length records.
> > 
> > The attached patches addresses both issues and allows us to build a
> > robust testsuite for authentication and authorization logging!
> > 
> > Please review!
> 
> Can you split this into separate patchsets for the serverid database
> problem and the incomplete python problem ? It's a little confusing
> having them mixed together like this.
> 
> In addition I'm assuming we'll need a bug logged for the serverid
> database
> bug, and the commit messages for that fix should be tagged with the
> BUG: https://.... url.
> 
> Thanks for finding and fixing this !

Thanks.  I did that and addressed the 80 column yesterday, and they
have been up on the auth-logging branch since last night.  I've also
rebased on metze's patches (thanks!). 

BTW, I realised later that you were entirely correct to not that
further pymessaging patches, not strictly required for this bug, where
included in the patch sent here. 

Thanks,

Andrew Bartlett