[PATCH] Updated Add detailed authentication logging for NTLM authentication.

[Andrew Bartlett]

On Mon, 2017-03-13 at 09:05 +0100, Stefan Metzmacher via samba-
technical wrote:
> Hi Gary,
> 
> > Updated to use jansson for the JSON generation, removing the glib
> > dependencies. We're planning to get the tests written tomorrow,
> > which
> > will finish this piece of work off.
> > 
> > Samples of the new log lines below, line breaks and indent added
> > for
> > clarity.
> > 
> > Authorization
> > 
> > Human Readable
> > 	Successful AuthZ: [DCE/RPC,ncacn_np]
> > 	user [NT AUTHORITY]\[SYSTEM] [S-1-5-18]
> > 	at [Mon, 13 Mar 2017 16:17:57 NZDT]
> > 	Remote host [ipv6::::0] local host [ipv6::::0]
> 
> Can we get the hires=true timestamp here as well?
> 
> 
> I think we've learned our lesson of having pytalloc_Object
> as a public structure. Please don't make TeventContext_Object
> public...
> 
> pytevent_Context_AsTeventContext() should be a function.
> In addition we should have a pytevent_Context_Check() function,
> which will also be used within pytevent_Context_AsTeventContext()
> before casting/dereferencing the struct elements.

That means adding a whole pytevent-util like we have with pytalloc and
pyldb.  I'm not sure it is worth it - the alternative is to just extend
pymessaging to have an tevent_loop_once() wrapper waiting for one
message.  

I wanted to do this in good python, plugging the bits together, but it
is becoming more work than makes sense...

> I haven't looked at the rest yet...

Thanks for the comments.  

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba