[PATCH] Updated Add detailed authentication logging for NTLM authentication.

Stefan Metzmacher metze at samba.org
Mon Mar 13 08:05:32 UTC 2017


Hi Gary,

> Updated to use jansson for the JSON generation, removing the glib
> dependencies. We're planning to get the tests written tomorrow, which
> will finish this piece of work off.
> 
> Samples of the new log lines below, line breaks and indent added for
> clarity.
> 
> Authorization
> 
> Human Readable
> 	Successful AuthZ: [DCE/RPC,ncacn_np]
> 	user [NT AUTHORITY]\[SYSTEM] [S-1-5-18]
> 	at [Mon, 13 Mar 2017 16:17:57 NZDT]
> 	Remote host [ipv6::::0] local host [ipv6::::0]

Can we get the hires=true timestamp here as well?


I think we've learned our lesson of having pytalloc_Object
as a public structure. Please don't make TeventContext_Object
public...

pytevent_Context_AsTeventContext() should be a function.
In addition we should have a pytevent_Context_Check() function,
which will also be used within pytevent_Context_AsTeventContext()
before casting/dereferencing the struct elements.

I haven't looked at the rest yet...

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170313/6fa144e2/signature.sig>


More information about the samba-technical mailing list