[PATCH] Make make testenv more reliable

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Jun 16 09:20:50 UTC 2017


Hi!

Review appreciated!

Thanks, Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 0c43b77c4a98e0dbb8e45e8edcf6a6a189549bd6 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Thu, 15 Jun 2017 17:36:58 +0200
Subject: [PATCH] selftest: Give tmux a bit of time to establish

I've seen a lot of failures with make testenv telling that stdin returns
EAGAIN. I haven't fully diagnosed it, but this seems to fix it. Now
make testenv is much more reliable.

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 selftest/in_screen | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/selftest/in_screen b/selftest/in_screen
index 36c3da1..5aba08d 100755
--- a/selftest/in_screen
+++ b/selftest/in_screen
@@ -77,6 +77,10 @@ if [[ "$TMUX" ]]; then
     fi
 
     $TMUX_CMD new-window -n test:$SERVERNAME "bash $basedir/$SERVERNAME.launch"
+
+    # tmux seems to lag a bit for new sessions. Don't create them too
+    # quickly one after another
+    sleep .1
 else
     screen -r -X screen -t test:$SERVERNAME bash $basedir/$SERVERNAME.launch
 fi
-- 
2.1.4



More information about the samba-technical mailing list