abort() calls from messaging code
jra at samba.org
Thu Jun 15 19:41:47 UTC 2017
On Thu, Jun 15, 2017 at 09:37:33PM +0200, Volker Lendecke wrote:
> On Thu, Jun 15, 2017 at 11:31:32AM -0700, Jeremy Allison via samba-technical wrote:
> > OK, just wanna write this down (and may append the commit message)
> > just to prove I understand the fix (please confirm :-).
> Full Ack on the whole mail :-)
> Thanks for writing it down. I had tried to do the handover from the
> helper thread to the main thread in a simpler way, but I really could
> not find any that would survive all tests that I did at the time. In
> particular I tried hard to avoid the event_ctx_mutex, but that seems
> difficult to achieve if you want to be able to destroy a pthreadpool
> or event context while threads are blocked hard somewhere and
> eventually wake up.
I wouldn't worry too much about that. It's an amazing piece of
work, I'm just impressed how you handle the complexity here.
I can follow it once it's written down, but I don't think I'd
be capable of creating such a thing :-).
More information about the samba-technical