[PATCH] Fix the FreeBSD build

Andrew Bartlett abartlet at samba.org
Wed Jun 7 10:09:50 UTC 2017

On Wed, 2017-06-07 at 11:24 +0200, Ralph Böhme via samba-technical
> Hi Gary,
> On Tue, Jun 06, 2017 at 11:12:50AM +1200, Gary Lockyer via samba-technical wrote:
> > I don't see a problem, I was hoping to have the wrapped version of
> > strerror_r done on Friday.  But it's causing issues with hiemdal, and
> > I've yet to get a clean test run, which suggests I'm still missing
> > something.
> ok, thanks for confirming. So I went ahead and pushed Volker's fix.

I think I finally have a patch set that allows us to use strerror_r. 
It certainly was a fight!

However the FreeBSD 9 build fails for me for other reasons, I had to

iff --git a/lib/replace/system/network.h b/lib/replace/system/network.h
index 8254551..1fe53ad 100644
--- a/lib/replace/system/network.h
+++ b/lib/replace/system/network.h
@@ -75,9 +75,10 @@
 #include <netinet/ip.h>
-#ifdef HAVE_NET_IF_H
 #include <net/if.h>
+#include <net/if_var.h>
+#include <net/if_types.h>
and revert 1670d00be88108a483f04c9763012504499b99e4.

Once I did that, the attached built.  It also builds on Linux.

I think we need to talk about ways to get a more diverse set of build
hosts into our CI process.  I have some ideas around using GitLab and
gitlab CI for that, I'll write more when I can make some specific


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-strerror_r-provide-XSI-compliant-strerror_r.patch
Type: text/x-patch
Size: 8937 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170607/633b5af3/0001-strerror_r-provide-XSI-compliant-strerror_r.bin>

More information about the samba-technical mailing list