[PATCH] Fix CID 1415704 Integer overflowed argument

Andreas Schneider asn at samba.org
Thu Jul 27 16:36:16 UTC 2017

On Thursday, 27 July 2017 18:25:46 CEST Volker Lendecke wrote:
> On Thu, Jul 27, 2017 at 04:02:00PM +0200, Andreas Schneider wrote:
> > before we push any patch to Samba we should fix it in uid_wrapper first.
> > The reason is that we want to avoid reverting patches when we update to a
> > new version of uid_wrapper in Samba. So fixing it upstream first is
> > important.
> > 
> > Are you ok with the attached patchset? If yes I would push them to
> > uid_wrapper upstream and then submit your patch for the Samba tree to
> > autobuild.
> My problem is that it can take really, really long until enough
> patches have piled up to justify going through the wrapper release
> process and then going through another round of review to finally get
> the stuff into Samba. Having to wait many weeks to get a bugfix into
> Samba stretches my patience a lot.

We are fine applying individual patches to Samba if it is urgent. The last 
time I've asked if it can wait till I do a release. We never set it as a hard 
rule and we fixed issues in Samba before without doing a release of a wrapper.

We can continue arguing here for the next weeks but this will not get the 
patches in ...

> Also, if we did the right thing and not push the wrappers in one huge
> blob patch but in individual patches to keep the proper history also
> in Samba, we would not have a problem. The patches pushed to Samba in
> advance would just be eliminated by a rebase because they already
> exist. So if we followed good engineering practices, there would not
> be any conflict at all.

Good engineering practice would be to *NOT* have them in the Samba source 
tree! But I think we disagree on that ...


Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list