[PATCH] g_lock_ping_pong

[Stefan Metzmacher]

Am 20.07.2017 um 10:57 schrieb Ralph Böhme via samba-technical:
> On Thu, Jul 20, 2017 at 10:42:59AM +0200, Volker Lendecke wrote:
>> On Wed, Jul 19, 2017 at 09:45:57AM +0200, Ralph Böhme wrote:
>>> On Sat, Jul 15, 2017 at 08:06:29AM +0200, Volker Lendecke wrote:
>>>> On Fri, Jul 14, 2017 at 02:39:38PM +0200, Ralph Böhme via samba-technical wrote:
>>>>>> nah, I'll try to swallow the big pill. :)
>>>>>
>>>>> doesn't apply to master, can you check?
>>>>
>>>> The attached patchset survived a private autobuild against master as
>>>> of Friday around noon, and rebases properly on current master.
>>>
>>> ok, took me a while to get through. Really really nice cleanup!
>>>
>>> Everything reviewed-by-me, accept the missing lock-order checks already
>>> mentioned over phone and a few commits that should be squashed to avoid
>>> EFUNCTIONDEFINEDBUTNOTUSED, see: 
>>
>> I'd propose a different approach: We should make the functions public
>> with a header file in one commit, remove their use in a second commit
>> and then remove the then-public functions in a third one. This ensures
>> full autobuildability in every commit and also maintains a clean patch
>> history.
>>
>> Comments?
> 
> if you prefer, I don't really care. :)

I typically use '#if 0' and '#endif' that to avoid to much changes.

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170720/e607040f/signature.sig>