[PATCH] Enable TDB mutexes by default in dbwrap and ctdb

Ralph Böhme slow at samba.org
Mon Jul 10 16:51:03 UTC 2017


Hi Amitay,

On Tue, Jul 11, 2017 at 01:06:07AM +1000, Amitay Isaacs wrote:
> Reviewed-by: Amitay Isaacs <amitay at gmail.com>

Thanks!

> I missed modifying dbwrap code with the latest change regarding calculation
> of tdb_flags.
> Here are 2 additional patches that are required.
> 
> 1. Do not pass tdb_flags to db attach controls
> 2. Ask CTDB for tdb open flags

afaict 2 result in TDB_SEQNUM not being enabled anymore. Afair this gets
requested on open by the client (ie smbd/dbwrap) and is never enabled in ctdb
without a CTDB_CONTROL_ENABLE_SEQNUM control?

Cheerio!
-slow



More information about the samba-technical mailing list