[PATCH] Enable TDB mutexes by default in dbwrap and ctdb

[Amitay Isaacs]

Hi Ralph,

On Mon, Jul 10, 2017 at 9:56 PM, Ralph Böhme <slow at samba.org> wrote:

> On Mon, Jul 10, 2017 at 09:41:52PM +1000, Martin Schwenke wrote:
> > Hi Ralph,
> >
> > On Mon, 10 Jul 2017 12:17:50 +0200, Ralph Böhme <slow at samba.org> wrote:
> >
> > > as discussed previously, attached patchset enables TDB mutexes by
> default in
> > > dbwrap and in ctdb.
> > >
> > > Amitay and Martin: did I miss any pieces in ctdb?
> > >
> > > I filed a bugnumber for this to get it into 4.7.
> > >
> > > Please review.
> >
> > -     { "TDBMutexEnabled", 0, false,
> > +     { "TDBMutexEnabled", 0, true,
> >
> > 2nd element is the tunable value, 3rd is whether it is obsolete.  So
> > you really want:
> >
> > +     { "TDBMutexEnabled", 1, false,
> >
> > :-)
>
> argl.
>
> Updated patch attached.
>
>

Reviewed-by: Amitay Isaacs <amitay at gmail.com>

I missed modifying dbwrap code with the latest change regarding calculation
of tdb_flags.
Here are 2 additional patches that are required.

1. Do not pass tdb_flags to db attach controls
2. Ask CTDB for tdb open flags

Please review and include them along with your patches.

Amitay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbwrap.patch
Type: text/x-patch
Size: 3938 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170711/200f4631/dbwrap.bin>