[PATCH] waf: backport finding of pkg-config

[Jeremy Allison]

On Mon, Jan 23, 2017 at 09:07:09AM +0200, Uri Simchoni wrote:
> Hi,
> 
> The attached patch backports the logic of finding pkg-config from
> upstream waf. Specicially, it allows overriding pkg-config using the
> PKGCONFIG environment variable - this can be useful for cross builds.
> 
> The patch also includes a small change of behavior - it omits the
> --print-errors and --errors-to-stdout switches, for the sake of being
> compatible with upstream waf. I was unable to associate the use of those
> switches with an early waf version or with a Samba-specific change, but
> as if my understanding of pkg-config is correct, the --print-errors
> switch is for Humans, and should not affect the correctness of the
> configure tests.
> 
> Review appreciated.
> Thanks,
> Uri

LGTM. rb+. Will push once my current autobuild finishes.