[PATCH] waf: backport finding of pkg-config

Uri Simchoni uri at samba.org
Mon Jan 23 07:07:09 UTC 2017


Hi,

The attached patch backports the logic of finding pkg-config from
upstream waf. Specicially, it allows overriding pkg-config using the
PKGCONFIG environment variable - this can be useful for cross builds.

The patch also includes a small change of behavior - it omits the
--print-errors and --errors-to-stdout switches, for the sake of being
compatible with upstream waf. I was unable to associate the use of those
switches with an early waf version or with a Samba-specific change, but
as if my understanding of pkg-config is correct, the --print-errors
switch is for Humans, and should not affect the correctness of the
configure tests.

Review appreciated.
Thanks,
Uri
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pkg-config-override.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170123/1fabb439/pkg-config-override.patch>


More information about the samba-technical mailing list