[PATCH] Fix wrong talloc context, remove queue_destructor and minor updates.
Swen Schillig
swen at vnet.ibm.com
Thu Dec 14 07:49:57 UTC 2017
On Thu, 2017-12-14 at 10:33 +1100, Amitay Isaacs wrote:
> Hi Swen,
>
> Patches look good, but I think they are incomplete. The file
> ctdb_io.c requires a bit of clean up.
>
> I have abstracted the functionality of common/ctdb_io.c without
> reference to ctdb_context in common/sock_io.c. If you are interested
> in improving the packet handling code, I would suggest you make the
> relevant changes to common/sock_io.c. It already has some tests and
> it's much easier to add tests for an abstraction that does not
> involve
> ctdb_context.
>
> The next step would be to simplify ctdb_io.c using sock_io
> abstraction. That way any improvements to sock_io are usable by ctdb
> daemon and it avoids having to fix the code in two places.
>
> Amitay.
>
Thanks Amitay
I will do that...trying to get it done today.
Cheers Swen
More information about the samba-technical
mailing list