[PATCH] Fix CTDB protocol marshalling

Martin Schwenke martin at meltin.net
Wed Aug 30 03:24:58 UTC 2017


On Mon, 28 Aug 2017 15:36:52 +0200, Volker Lendecke via samba-technical
<samba-technical at lists.samba.org> wrote:

> On Mon, Aug 28, 2017 at 11:22:21PM +1000, Amitay Isaacs wrote:
> > If required, yes, we can.  Question is whether it's needed now, or it can
> > wait.  
> 
> Of course it can wait. This is not a functional issue. I just wanted
> to point out that I've gone through big pain the past avoiding malloc
> for performance reasons. I have been there with the very controversial
> talloc_stack/talloc_pool thing, Metze has been there with performance
> work on SMB2 on ARM. If I understood Andrew Bartlett's patches right,
> he is right now going through the same. So it might have been a point
> to consider to avoid malloc right from the start when designing an
> API.

OK, I've now pushed this.  Let's change the API later.

peace & happiness,
martin



More information about the samba-technical mailing list