[PATCH] Fix CTDB protocol marshalling

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Aug 28 13:36:52 UTC 2017

On Mon, Aug 28, 2017 at 11:22:21PM +1000, Amitay Isaacs wrote:
> If required, yes, we can.  Question is whether it's needed now, or it can
> wait.

Of course it can wait. This is not a functional issue. I just wanted
to point out that I've gone through big pain the past avoiding malloc
for performance reasons. I have been there with the very controversial
talloc_stack/talloc_pool thing, Metze has been there with performance
work on SMB2 on ARM. If I understood Andrew Bartlett's patches right,
he is right now going through the same. So it might have been a point
to consider to avoid malloc right from the start when designing an


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list