[PATCH] Re: ldb cmocka tests

[Andrew Bartlett]

On Tue, 2017-04-25 at 09:14 +1200, Andrew Bartlett via samba-technical
wrote:
> On Thu, 2017-04-20 at 14:32 +0200, Andreas Schneider wrote:
> > On Friday, 7 April 2017 05:18:02 CEST Andrew Bartlett via samba-
> > technical 
> > wrote:
> > > Now with actual patches :-)
> > 
> > Autobuild fails with:
> > 
> > ERR: Invalid attribute syntax : "Invalid attribute value in an
> > @ATTRIBUTES 
> > entry" on DN @ATTRIBUTES at block before line 3
> >   File "tests/python/api.py", line 1325
> >     except LdbError, err:
> >                    ^
> > SyntaxError: invalid syntax
> > 
> > 
> > Can you please fix it, thanks!
> 
> Thanks.  It was not python3 compatible.  I'm really glad the
> autobuild
> caught it, as I hadn't specified that option to my configure line
> while
> testing.  
> 
> Another good reason why all our patches need to go via some CI system
> before wasting your time with the final autobuild I guess :-)
> 
> I'll run a private autobuild, but this much passes an autobuild on
> ldb
> only, so should be good.

It fails with:

[1292/4123] Compiling lib/param/loadparm_server_role.c
../lib/ldb/tests/ldb_mod_op_test.c: In function
test_ldb_search_against_transaction_callback1:
../lib/ldb/tests/ldb_mod_op_test.c:1305:8: error: ignoring return value
of write, declared with attribute warn_unused_result [-Werror=unused-
result]
   write(pipes[1], "GO", 2);
        ^
../lib/ldb/tests/ldb_mod_op_test.c:1316:6: error: ignoring return value
of read, declared with attribute warn_unused_result [-Werror=unused-
result]
  read(pipes[0], buf, 2);
      ^

I'll address this later, but for now I have a wonderful sunny day to
explore on a bike, so adding (void) prefixes will have to wait. 

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba