[PATCH] Re: ldb cmocka tests

[Andrew Bartlett]

On Thu, 2017-04-20 at 14:32 +0200, Andreas Schneider wrote:
> On Friday, 7 April 2017 05:18:02 CEST Andrew Bartlett via samba-
> technical 
> wrote:
> > Now with actual patches :-)
> 
> Autobuild fails with:
> 
> ERR: Invalid attribute syntax : "Invalid attribute value in an
> @ATTRIBUTES 
> entry" on DN @ATTRIBUTES at block before line 3
>   File "tests/python/api.py", line 1325
>     except LdbError, err:
>                    ^
> SyntaxError: invalid syntax
> 
> 
> Can you please fix it, thanks!

Thanks.  It was not python3 compatible.  I'm really glad the autobuild
caught it, as I hadn't specified that option to my configure line while
testing.  

Another good reason why all our patches need to go via some CI system
before wasting your time with the final autobuild I guess :-)

I'll run a private autobuild, but this much passes an autobuild on ldb
only, so should be good.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldb-Add-some-tests-to-clarify-the-current-iterator-b.patch
Type: text/x-patch
Size: 4350 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170425/4bc15fd4/0001-ldb-Add-some-tests-to-clarify-the-current-iterator-b.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ldb-Add-test-for-transaction-deadlock-detected-when-.patch
Type: text/x-patch
Size: 7358 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170425/4bc15fd4/0002-ldb-Add-test-for-transaction-deadlock-detected-when-.bin>