[PATCH] vfs_acl_xattr|tdb: set create mask to 0777 if ignore_system_acls is set

Ralph Böhme slow at samba.org
Wed Apr 19 14:43:19 UTC 2017


On Wed, Apr 19, 2017 at 10:22:39AM -0400, jim wrote:
> Your test should be (create_mask & 0777) != 0666 to see if create_mask is
> not exactly 0666.

oh, no. I just want it to be *at least* 0666, not exactly 0666.

> You only test the 0666 bits which isn't the same thing.
> create_mask could be 0767 and pass your test.

Which is what I want. :)

-slow



More information about the samba-technical mailing list