[PATCH] vfs_acl_xattr|tdb: set create mask to 0777 if ignore_system_acls is set

jim jim.brown at rsmas.miami.edu
Wed Apr 19 14:22:39 UTC 2017

Your test should be (create_mask & 0777) != 0666 to see if create_mask 
is not exactly 0666.
You only test the 0666 bits which isn't the same thing.
create_mask could be 0767 and pass your test.

On 4/19/2017 10:08 AM, Ralph Böhme wrote:
> On Wed, Apr 19, 2017 at 09:13:11AM -0400, jim via samba-technical wrote:
>> You need an else case to set and display the create mask with DBG_NOTICE if
>> (create_mask & 0666) == 0666.
> er, why? If the create mask is exactly 0666 I *want* to leave it as it and *not*
> change it and *not* log it. But maybe I'm just overly stupid and am still
> missing the point. If that's the case, please spell it out in large letters so I
> can understand. :)
> Thanks!
> -slow

More information about the samba-technical mailing list