[PATCH] some cleanups for smbldap.c

Ralph Böhme slow at samba.org
Wed Apr 19 14:41:36 UTC 2017

On Wed, Apr 19, 2017 at 04:20:36PM +0200, vl--- via samba-technical wrote:
> The main focus is to make "struct smbldap_state" private to smbldap.c
> for better encapsulation.

+1 for the encapsulation but can we possibly use a different name then
smbldap_get_ld() ? The ld makes it look like you could get a linker out of
smbldap. :)

Maybe smbldap_get_ldap() ?

If you don't agree and would like to stick with smbldap_get_ld() please go ahead
and push with my rb.

If you agree but wonder how to rename without revisiting every file, sed inplace
would do the trick, so

$ find . -name '*.c' | xargs sed -i s/smbldap_get_ld/smbldap_get_ldap/g
$ find . -name '*.h' | xargs sed -i s/smbldap_get_ld/smbldap_get_ldap/g

If you want you can offload the task, I can do it, just tell me I should go
ahead and push with this change.


More information about the samba-technical mailing list