[PATCH] some cleanups for smbldap.c

vl at samba.org vl at samba.org
Wed Apr 19 15:11:29 UTC 2017

On Wed, Apr 19, 2017 at 04:41:36PM +0200, Ralph Böhme via samba-technical wrote:
> On Wed, Apr 19, 2017 at 04:20:36PM +0200, vl--- via samba-technical wrote:
> > The main focus is to make "struct smbldap_state" private to smbldap.c
> > for better encapsulation.
> +1 for the encapsulation but can we possibly use a different name then
> smbldap_get_ld() ? The ld makes it look like you could get a linker out of
> smbldap. :)
> Maybe smbldap_get_ldap() ?
> If you don't agree and would like to stick with smbldap_get_ld() please go ahead
> and push with my rb.
> If you agree but wonder how to rename without revisiting every file, sed inplace
> would do the trick, so
> $ find . -name '*.c' | xargs sed -i s/smbldap_get_ld/smbldap_get_ldap/g
> $ find . -name '*.h' | xargs sed -i s/smbldap_get_ld/smbldap_get_ldap/g
> If you want you can offload the task, I can do it, just tell me I should go
> ahead and push with this change.

Pushed it with that change. It made a few lines bump off the 80 chars,
so this is a few more + in the patch :-)



More information about the samba-technical mailing list