[WIP] Add tests for supplementalCredentials, store other hash types

Gary Lockyer gary at catalyst.net.nz
Tue Apr 11 05:16:06 UTC 2017


Updated patch set
includes changes and tests for the samba-tool user command

There are some outstanding whitespace fixes, and another two tests to
add. I'll be doing the changes tomorrow morning.

Once the changes are made I'm hoping to get two team reviews, and the
code landed.

Any comments greatly appreciated.

Thanks
Gary


> On 06/04/17 08:22, Gary Lockyer via samba-technical wrote:
>> Revised patch set attached.
>> - tests renamed
>> - unused imports removed
>> - white space after brackets removed
>>
>>
>> On 05/04/17 17:03, Andrew Bartlett via samba-technical wrote:
>>> On Wed, 2017-04-05 at 07:06 +1200, Gary Lockyer via samba-technical
>>> wrote:
>>>> Subject: [PATCH 1/6] password_hash: Add tests to allow refactoring
>>>>
>>>> Add tests for password_hash.c to allow refactoring of
>>>> setup_supplemental_field
>>>
>>> In this patch there are quite a few references to userPassword that
>>> should be supplementalCredentials.  I see you fix those up later, but
>>> if you could pull those into this patch, we should be able to get this
>>> much upstream.
>>>
>>> Thanks,
>>>
>>> Andrew Bartlett
>>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-idl-drsblobs-add-the-blobs-required-for-Primary-user.patch
Type: text/x-patch
Size: 2419 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170411/e23203a8/0001-idl-drsblobs-add-the-blobs-required-for-Primary-user-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-docs-configuration-options-for-Primary-userPassword.patch
Type: text/x-patch
Size: 6897 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170411/e23203a8/0002-docs-configuration-options-for-Primary-userPassword-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-tests-password_hash-add-tests-for-Primary-userPasswo.patch
Type: text/x-patch
Size: 17546 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170411/e23203a8/0003-tests-password_hash-add-tests-for-Primary-userPasswo-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-password_hash-generate-and-store-Primary-userPasswor.patch
Type: text/x-patch
Size: 10797 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170411/e23203a8/0004-password_hash-generate-and-store-Primary-userPasswor-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-samba-tool-tests-Tests-for-virtualWDigest-and-virtua.patch
Type: text/x-patch
Size: 18425 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170411/e23203a8/0005-samba-tool-tests-Tests-for-virtualWDigest-and-virtua-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-samba-tool-user-add-support-for-userPassword-and-WDi.patch
Type: text/x-patch
Size: 13043 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170411/e23203a8/0006-samba-tool-user-add-support-for-userPassword-and-WDi-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170411/e23203a8/signature-0001.sig>


More information about the samba-technical mailing list