[WIP] Add tests for supplementalCredentials, store other hash types

Gary Lockyer gary at catalyst.net.nz
Fri Apr 7 02:13:34 UTC 2017


Updated patch set.
- Multiple hashes can be specified for userPassword
- added parameters
	'additional password hash sha256 rounds'
	'additional password hash sha512 rounds'
  To control the number of hashing rounds on a per algorithm
  basis.

Next patches will change sambatool syncpassword
- to return the WDigest values
- if a userPassword hash exists it will be returned for
  virtualCryptSHA256 virtualCryptSHA512. rather than
  calculating the value.

I believe these patches are ready for review, so review and comment
appreciated.

Gary

On 06/04/17 08:22, Gary Lockyer via samba-technical wrote:
> Revised patch set attached.
> - tests renamed
> - unused imports removed
> - white space after brackets removed
> 
> 
> On 05/04/17 17:03, Andrew Bartlett via samba-technical wrote:
>> On Wed, 2017-04-05 at 07:06 +1200, Gary Lockyer via samba-technical
>> wrote:
>>> Subject: [PATCH 1/6] password_hash: Add tests to allow refactoring
>>>
>>> Add tests for password_hash.c to allow refactoring of
>>> setup_supplemental_field
>>
>> In this patch there are quite a few references to userPassword that
>> should be supplementalCredentials.  I see you fix those up later, but
>> if you could pull those into this patch, we should be able to get this
>> much upstream.
>>
>> Thanks,
>>
>> Andrew Bartlett
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-idl-drsblobs-add-the-blobs-required-for-Primary-user.patch
Type: text/x-patch
Size: 2419 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170407/57bdd93d/0001-idl-drsblobs-add-the-blobs-required-for-Primary-user.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-docs-configuration-options-for-Primary-userPassword.patch
Type: text/x-patch
Size: 6897 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170407/57bdd93d/0002-docs-configuration-options-for-Primary-userPassword.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-tests-password_hash-add-tests-for-Primary-userPasswo.patch
Type: text/x-patch
Size: 16983 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170407/57bdd93d/0003-tests-password_hash-add-tests-for-Primary-userPasswo.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-password_hash-generate-and-store-Primary-userPasswor.patch
Type: text/x-patch
Size: 10154 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170407/57bdd93d/0004-password_hash-generate-and-store-Primary-userPasswor.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170407/57bdd93d/signature.sig>


More information about the samba-technical mailing list